Bug #2883: Add Orientation Change Support in 3.0 (includes sample code for iOS and Android) | Cocos2d-x

We are migrating issue tracker of Cocos2d-x Project to Github, please create new issue there. Thanks.

Add Orientation Change Support in 3.0 (includes sample code for iOS and Android)

Bug #2883 [Closed]

schngrg 2013-10-06 10:52 . Updated over 8 years ago

It is easy to add support for orientation change in cocos2dx if we add the following code:

For IOS
In AppController.mm, in didFinishLaunchingWithOptions, add:

[[NSNotificationCenter defaultCenter] addObserver:self
selector:`selector(handleDidChangeStatusBarOrientationNotification:)
name:UIApplicationDidChangeStatusBarOrientationNotification
object:nil];

In AppController.mm, add:

(void)handleDidChangeStatusBarOrientationNotification:(NSNotification )notification; { //NSLog(`“The orientation is %@”, [notification.userInfo objectForKey: UIApplicationStatusBarOrientationUserInfoKey]); cocos2d::Director\ director = cocos2d::CCDirector::getInstance(); cocos2d::EGLView* eglView = director~~>getOpenGLView; AppDelegate::onOrientationChange, eglView~~>getFrameSize().width, eglView~~>getFrameSize.height); } Android Code

Common Code
In AppDelegate.h, add:
void onOrientationChange;
In AppDelegate.cpp, add {
Size sSystem; // size that OS tells us
Size sActual; // size that we need to use in cocos2dx
if {
sActual.width = std::max;
sActual.height = std::min;
} else {
sActual.width = std::min;
sActual.height = std::max;
}
cocos2d::Director* director = cocos2d::CCDirector::getInstance;
EGLView* eglView = director~~>getOpenGLView();
eglView~~>setFrameSize;
eglView~~>setDesignResolutionSize(sActual.width, sActual.height, ResolutionPolicy::SHOW_ALL);
cocos2d::CCDirector::getInstance()->replaceScene(/* getCurrentScene()*/); //reload current scene to redraw it for new screen size, or an app might choose to do something different
}

schngrg 2013-10-06 23:56

Android Code

In Android main.cpp, add:

void onNativeWindowRedrawNeededCallback(ANativeActivity* activity, ANativeWindow* window) {
    int w = ANativeWindow_getWidth(window);
    int h = ANativeWindow_getHeight(window);
    LOGD ("Window New Size %d %d", w, h);
    AppDelegate::onOrientationChange(w>h, w, h); //this call causes a crash, due to JNI and GL threads mismatch. We need to use runOnGLThread here.
}

void cocos_android_app_init (struct android_app* app) {
    LOGD("cocos_android_app_init");
    AppDelegate *pAppDelegate = new AppDelegate();
    app->activity->callbacks->onNativeWindowRedrawNeeded = &onNativeWindowRedrawNeededCallback;
}

// Above Android code gives JNI ERROR: env->self != thread-self, the cocos scene reset function should be called on GL thread using proposed cocos2d::ThreadHelper::runOnGLThread(func); but I couldn’t find it in 3.0 alpha0. Is it already implemented or is there some other workaround to do this on GL thread?

// Also, I didn’t use onNativeWindowResized because is only called ‘sometimes’, and I couldn’t tell why. onNativeWindowRedrawNeeded seems more reliable.

schngrg 2013-10-07 00:07

The above code takes care of some issues like: height and width of visible screen area stay the same for full screen apps, but on Android devices like Nexus4 with on-screen buttons or with not-full-screen iOS apps with status bar visible, app window’s visible height and width change on orientation change because of new location of buttons and status bar.

Another issue with IOS is that width and height values are not swapped after orientation change, above code manually checks if it is landscape or portrait, and then swap the height/width values if needed.

Only pending issue is “JNI ERROR: env->self != thread-self” on Android which can be solved by runOnGLThread. If runOnGLThread is not implemented yet, this can be hacked for now using schedule_once or some other better way.

schngrg 2013-10-08 12:48

Another alternate way to hook up orientation change callback on Android. This one doesn’t need any thread helper etc… as we use the main loop in native activity which is already our main thread.

In nativeactivity.cpp, in engine_handle_cmd(), add:

        case APP_CMD_CONFIG_CHANGED:
            int w = ANativeWindow_getWidth(app->window);
            int h = ANativeWindow_getHeight(app->window);
            LOGI("Window New Size %d %d", w, h);
            AppDelegate::onOrientationChange(w>h, w, h);
            break;

ondesly 2013-10-10 12:22

Sachin Garg wrote:

Another alternate way to hook up orientation change callback on Android. This one doesn’t need any thread helper etc… as we use the main loop in native activity which is already our main thread.
>
In nativeactivity.cpp, in engine_handle_cmd(), add:
>
[…]
Unfortunately, this way doesn’t work. w and h have old values, before changing. We need to find another way to get them.

ondesly 2013-10-10 14:49

I sent pull request to fix this bug
https://github.com/cocos2d/cocos2d-x/pull/3880

schngrg 2013-10-10 15:22

Dmitriy Torkhov wrote:

Unfortunately, this way doesn’t work. w and h have old values, before changing. We need to find another way to get them.

I have implemented orientation change in my app using this, and I am getting new width and height value when I use ANativeWindow_getWidth after APP_CMD_CONFIG_CHANGED .

After I saw your comment, I again tested on Nexus7 and it is working as expected. Can you please share more details of how you tested or if you changed anything in code, then I can try that on my side too.

schngrg 2013-10-10 15:32

OK, I tested more and can see the problem. When rotating device to left I get new values from APP_CMD_CONFIG_CHANGED but when rotating device to right I get old values. Maybe we need to try APP_CMD_WINDOW_RESIZED, APP_CMD_WINDOW_REDRAW_NEEDED or APP_CMD_CONTENT_RECT_CHANGED.

schngrg 2013-10-16 10:20

The android issue was fixed by Dmitriy Torkhov in his pull request (but the pull request was closed as it didn’t implement the changes in samples and for iOS).
https://github.com/cocos2d/cocos2d-x/pull/3917

schngrg 2013-11-04 18:14

Another pull request by Dmitriy Torkhov, includes iOS support too.
https://github.com/cocos2d/cocos2d-x/pull/3997

#10

zhangxm 2013-11-15 03:40